Include QueryBuilder implementations #3107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3107 +/- ##
=============================================
+ Coverage 51.89% 66.50% +14.61%
- Complexity 3344 4371 +1027
=============================================
Files 219 242 +23
Lines 13735 14207 +472
Branches 795 853 +58
=============================================
+ Hits 7128 9449 +2321
+ Misses 6361 4386 -1975
- Partials 246 372 +126
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sazzad16
requested changes
Sep 5, 2022
There was a problem hiding this comment.
@angelo147 Thank you for this PR and sorry for late reply.
Please address the change requests.
src/main/java/redis/clients/jedis/search/querybuilder/QueryBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/redis/clients/jedis/search/querybuilder/QueryBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/redis/clients/jedis/search/querybuilder/QueryNode.java
Outdated
Show resolved
Hide resolved
src/main/java/redis/clients/jedis/search/querybuilder/Values.java
Outdated
Show resolved
Hide resolved
src/main/java/redis/clients/jedis/search/querybuilder/Node.java
Outdated
Show resolved
Hide resolved
src/main/java/redis/clients/jedis/search/querybuilder/GeoValue.java
Outdated
Show resolved
Hide resolved
src/main/java/redis/clients/jedis/search/querybuilder/QueryNode.java
Outdated
Show resolved
Hide resolved
sazzad16
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #3060 i included the querybuilder package and QueryBuilderTest, also made some internal changes.